Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: use auto calculate if min /max is null #12215

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Feat: use auto calculate if min /max is null #12215

merged 3 commits into from
Mar 16, 2020

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Mar 2, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Use auto calculation when axis min/max's value is null

Fixed issues

Close #11829

Details

Screen Shot 2020-03-02 at 11 48 03

Before: What was the problem?

Screen Shot 2020-03-02 at 11 44 04

After: How is it fixed in this PR?

Screen Shot 2020-03-02 at 11 43 39

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 2, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang
Copy link
Contributor

pissang commented Mar 16, 2020

Nice fix!

@pissang pissang merged commit cf5812f into apache:master Mar 16, 2020
@susiwen8 susiwen8 deleted the #11829 branch March 16, 2020 06:00
100pah added a commit that referenced this pull request Apr 2, 2020
@100pah
fix: axis min/max function return null:
f3a6b9a 
The original PR is:  #12215
cf5812f
Fix from that:
(1) The min/max function call should not be called twice (necessary and probably wrong input params).
(2) `fixMin` `fixMax` should cover function return.
(3) Add more test cases.
@100pah 100pah mentioned this pull request Apr 2, 2020
Merged
100pah added a commit that referenced this pull request Apr 2, 2020
@100pah
fix: axis min/max function return null:
fb72a4c 
The original PR is:  #12215
cf5812f
Fix from that:
(1) The min/max function call should not be called twice (necessary and probably wrong input params).
(2) `fixMin` `fixMax` should cover function return.
(3) Add more test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

min/max callback of yAxis support return null
2 participants
@susiwen8 @pissang